Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 Fix plugin loading on Windows #1841

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Feb 6, 2025

Fixes #869

This PR resolves paths as file URLs to ensure that import works on all systems. The fact that it doesn't fail for Linux is because / is implicitly a file path, whereas on Windows C:/ is treated as a URL with scheme C:.

Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: e3606aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
myst-cli Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agoose77 agoose77 force-pushed the agoose77/fix-test-plugin-windows branch from c49a8de to 82bb16e Compare February 6, 2025 12:12
@agoose77 agoose77 merged commit 2a6db55 into main Feb 6, 2025
7 checks passed
@agoose77 agoose77 deleted the agoose77/fix-test-plugin-windows branch February 6, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins do not load on Windows
2 participants